Skip to content

fix: hide admin password in TF apply logs #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

fix: hide admin password in TF apply logs #526

wants to merge 15 commits into from
+58 −10

Conversation

@Aditya-ranjan-16
Copy link
Contributor

@Aditya-ranjan-16 Aditya-ranjan-16 commented Sep 20, 2025 •
edited
Loading

Description

Fixed the issue where the admin password was being exposed in terraform apply logs when Kibana is enabled.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This PR fixes the issue where the admin password was visible in Terraform apply logs Kibana is enabled.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

Verified the fix using CURL

Screenshot 2025-09-20 at 6 55 13 PM

now the updated logs are :

data.http.es_metadata[0]: Reading...
data.http.es_metadata[0]: Read complete after 1s [id=https://67284430-4705-472d-b1b4-746855e20dfb.bn2s2uid@up8mv7mv2ig.databases.appdomain.cloud:30163/]

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

3 similar comments
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

Ak-sky
Ak-sky previously approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@Ak-sky Ak-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ocofaigh
ocofaigh requested changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base64 is not good enough here - anyone can decrypt it. It needs to be properly masked. I suggest to create a separate PR for the index removal to unblock other PRs please

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

1 similar comment
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

1 similar comment
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

base64 is not good enough here - anyone can decrypt it. It needs to be properly masked. I suggest to create a separate PR for the index removal to unblock other PRs please

Added an external data script to fetch the metadata

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocofaigh ocofaigh ocofaigh requested changes

@Ak-sky Ak-sky Ak-sky left review comments

@daniel-butler-irl daniel-butler-irl Awaiting requested review from daniel-butler-irl daniel-butler-irl is a code owner

@shemau shemau Awaiting requested review from shemau shemau is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Aditya-ranjan-16 @Ak-sky @ocofaigh @shemau